Suggestion fields are not a subset of the fields of the original note

🐛 Bug
1

Before the error happened, I was…

Submitted a bulk suggestion and this card didn’t submit so went to submit individually and got this error

image
image1920×1009 131 KB

Error message (don't change this) 
Anki 24.04.1 (ccd9ca1a)  (ao)
Python 3.9.18 Qt 6.6.2 PyQt 6.6.1
Platform: Windows-10-10.0.22631

Traceback (most recent call last):

  File "C:\Users\shmue\AppData\Roaming\Anki2\addons21\1322529746\gui\suggestion_dialog.py", line 498, in accept
    self._callback(self.suggestion_meta())

  File "C:\Users\shmue\AppData\Roaming\Anki2\addons21\1322529746\gui\suggestion_dialog.py", line 107, in <lambda>
    callback=lambda suggestion_meta: _on_suggestion_dialog_for_single_suggestion_closed(

  File "C:\Users\shmue\AppData\Roaming\Anki2\addons21\1322529746\gui\suggestion_dialog.py", line 173, in _on_suggestion_dialog_for_single_suggestion_closed
    if suggestion_result == ChangeSuggestionResult.SUCCESS:

UnboundLocalError: local variable 'suggestion_result' referenced before assignment

Sentry link (for developers)

2

Tried resetting local changes and resubmitting but didn’t help

3

@abdo.nh

4

I can replicate these results. (even just trying to make changes to only the text field yields this error)

image
image2013×1400 261 KB

1 Like
5

Can someone upload their logs?

This is probably similar to this issue: Can't suggest new tag for card

7

How do I get them?

8

Go to AnkiHub > Help > Upload logs and post the filename shown.

9

ankihub_addon_logs_bc296_1716570582.log

11

@ProductTeam It’s similar to the issue in the linked post. In this case, it’s caused by note:1555364876545 missing the Lecture Notes field as can be seen here: Sign In

12

Was this because of the user who created this card that there is no lecture notes field?

I usually make all of these but I believe a few other maintainers made some in the past. I never have tampered with note types or changing fields/deleting fields so I very sure this was not me. Can this be fixed? Is this AnkiHub related?

13

Yes, I think that’s the reason.

14

I don’t recall who made this card, @herstein.jacob was it you? I don’t think its Thomas or Bilal (bilal made one but I don’t think its this one). I don’t think its me either because otherwise all the ones I made would be broken as well

15

I may have accepted this, but I wouldn’t be the one who made it

1 Like
16

Perhaps AnkiHub should have a way of detecting this and not accepting any cards that don’t have all the correct fields?

2 Likes
17

How do we go about fixing this?

18

It needs to be fixed programmatically, then we need to make AnkiHub reject new note suggestions with missing fields.

2 Likes
19

Oh so needs to be done on ur end before we’d be able to update?

Is there a way to check the whole deck to make sure there are no other cards with this issue so they all can be fixed?

20

Yes, we need to check the whole deck for missing fields.

1 Like
21

Heres another one: nid:1509224562620

image
image1875×731 85.9 KB